This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] Mark internal nss symbols with attribute_hidden [BZ #18822]


On 08/21/2017 01:46 PM, H.J. Lu wrote:
> On Mon, Aug 21, 2017 at 2:58 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 08/20/2017 07:18 PM, H.J. Lu wrote:
>>> diff --git a/grp/initgroups.c b/grp/initgroups.c
>>> index 0d5b841796..0ffb5ceea1 100644
>>> --- a/grp/initgroups.c
>>> +++ b/grp/initgroups.c
>>> @@ -37,7 +37,6 @@ typedef enum nss_status (*initgroups_dyn_function) (const char *, gid_t,
>>>                                                   gid_t **, long int, int *);
>>>
>>>  extern service_user *__nss_group_database attribute_hidden;
>>> -service_user *__nss_initgroups_database;
>>
>> The declaration of __nss_group_database is no longer necessary, either.
>>
>> I think these additional declarations can be removed as well"
>>
>> nscd/gai.c:service_user *__nss_hosts_database;
>> posix/tst-rfc3484-2.c:service_user *__nss_hosts_database attribute_hidden;
>> posix/tst-rfc3484-3.c:service_user *__nss_hosts_database attribute_hidden;
>> posix/tst-rfc3484.c:service_user *__nss_hosts_database attribute_hidden;
>> sysdeps/posix/getaddrinfo.c:extern service_user *__nss_hosts_database
>> attribute_hidden;
>>
> 
> Here is the updated patch.  Tested on x86-64.

Thanks, looks good.

Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]