This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/3] Mark internal nss symbols with attribute_hidden [BZ #18822]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 21 Aug 2017 14:26:54 +0200
- Subject: Re: [PATCH 2/3] Mark internal nss symbols with attribute_hidden [BZ #18822]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 859204E028
- References: <20170818203044.GB15188@gmail.com> <87inhioe3z.fsf@mid.deneb.enyo.de> <CAMe9rOq2rVEe4KU1-oM4qRZcb1q0Whw=nwbGV6o1vnP1o6X9Jw@mail.gmail.com> <a1c81a94-44c5-e54d-8531-7a6c4479e310@redhat.com> <CAMe9rOqbzFGf0gRDHxV-gavBSJ57s7_JcsZtAn+reD9kScMCuA@mail.gmail.com>
On 08/21/2017 01:46 PM, H.J. Lu wrote:
> On Mon, Aug 21, 2017 at 2:58 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 08/20/2017 07:18 PM, H.J. Lu wrote:
>>> diff --git a/grp/initgroups.c b/grp/initgroups.c
>>> index 0d5b841796..0ffb5ceea1 100644
>>> --- a/grp/initgroups.c
>>> +++ b/grp/initgroups.c
>>> @@ -37,7 +37,6 @@ typedef enum nss_status (*initgroups_dyn_function) (const char *, gid_t,
>>> gid_t **, long int, int *);
>>>
>>> extern service_user *__nss_group_database attribute_hidden;
>>> -service_user *__nss_initgroups_database;
>>
>> The declaration of __nss_group_database is no longer necessary, either.
>>
>> I think these additional declarations can be removed as well"
>>
>> nscd/gai.c:service_user *__nss_hosts_database;
>> posix/tst-rfc3484-2.c:service_user *__nss_hosts_database attribute_hidden;
>> posix/tst-rfc3484-3.c:service_user *__nss_hosts_database attribute_hidden;
>> posix/tst-rfc3484.c:service_user *__nss_hosts_database attribute_hidden;
>> sysdeps/posix/getaddrinfo.c:extern service_user *__nss_hosts_database
>> attribute_hidden;
>>
>
> Here is the updated patch. Tested on x86-64.
Thanks, looks good.
Florian