This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] Remove compat from DEFAULT_CONFIG lookup strings
- From: Steve Ellcey <sellcey at cavium dot com>
- To: libc-alpha <libc-alpha at sourceware dot org>
- Date: Thu, 17 Aug 2017 14:30:28 -0700
- Subject: [PATCH] Remove compat from DEFAULT_CONFIG lookup strings
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- Reply-to: sellcey at cavium dot com
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
This patch is based on the discussion string at:
https://sourceware.org/ml/libc-alpha/2017-08/msg00531.html
Basically a change was made to remove the nss compat lookup
method by default from glibc. It is available if glibc
is configured with --enable-obsolete-nsl. Some tests were
still using the compat lookup method because DEFAULT_CONFIG
still included that method in the files below. Depending on
how you test that might not cause any failures because if
libnss_compat could not be found in the glibc build directories
the dynamic linker would search the default host directories
and pick it up from there, only if it couldn't find it in
either place would the tests (grp/testgrp, nss/bug17079,
posix/globtest, and pwd/tst-getpwfail) fail.
This patch removes the compat lookup method from the
DEFAULT_CONFIG strings. Tested on x86 and aarch64 with
no regressions.
OK to checkin?
2017-08-17 Steve Ellcey <sellcey@cavium.com>
* nss/grp-lookup.c (DEFAULT_CONFIG): Remove compat method.
* nss/pwd-lookup.c (DEFAULT_CONFIG): Likewise.
* nss/spwd-lookup.c (DEFAULT_CONFIG): Likewise.
diff --git a/nss/grp-lookup.c b/nss/grp-lookup.c
index 8cb00aa..256d2af 100644
--- a/nss/grp-lookup.c
+++ b/nss/grp-lookup.c
@@ -17,6 +17,6 @@
<http://www.gnu.org/licenses/>. */
#define DATABASE_NAME group
-#define DEFAULT_CONFIG "compat [NOTFOUND=return] files"
+#define DEFAULT_CONFIG "files"
#include "XXX-lookup.c"
diff --git a/nss/pwd-lookup.c b/nss/pwd-lookup.c
index 00040d4..8612c39 100644
--- a/nss/pwd-lookup.c
+++ b/nss/pwd-lookup.c
@@ -17,6 +17,6 @@
<http://www.gnu.org/licenses/>. */
#define DATABASE_NAME passwd
-#define DEFAULT_CONFIG "compat [NOTFOUND=return] files"
+#define DEFAULT_CONFIG "files"
#include "XXX-lookup.c"
diff --git a/nss/spwd-lookup.c b/nss/spwd-lookup.c
index 319a7bb..2c866d1 100644
--- a/nss/spwd-lookup.c
+++ b/nss/spwd-lookup.c
@@ -18,6 +18,6 @@
#define DATABASE_NAME shadow
#define ALTERNATE_NAME passwd
-#define DEFAULT_CONFIG "compat [NOTFOUND=return] files"
+#define DEFAULT_CONFIG "files"
#include "XXX-lookup.c"