Re: [PATCH] i386: Do not set internal_function

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, Aug 14, 2017 at 5:35 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 08/14/2017 02:32 PM, H.J. Lu wrote:
>> On Mon, Aug 14, 2017 at 4:36 AM, Florian Weimer <fweimer@redhat.com> wrote:
>>> All calls to functions with the internal_function attribute
>>> have been removed from assembler implementations, which means that
>>> the definition of internal_function can be changed at the C level
>>> without causing ABI issues with assembler code.
>>>
>>> _dl_fixup still uses a regparm calling convention on i386, but this
>>> is controlled through ARCH_FIXUP_ATTRIBUTE, not internal_function.
>>>
>>> 2017-08-14  Florian Weimer  <fweimer@redhat.com>
>>>
>>>         i386: Do not set internal_function.
>>>         * config.h.in (USE_REGPARMS, internal_function): Remove.
>>>         * sysdeps/i386/configure.ac (USE_REGPARMS): Likewise.
>>>         * sysdeps/i386/configure (USE_REGPARMS): Likewise.
>>>
>>
>> Does include/libc-symbols.h still define internal_function?
>
> Yes, the macro generic definition is still present, but it expands to
> nothing.
>
> Completely removing internal_function is a separate cleanup.  I would
> like to tackle this on a per-subdirectory basis once this change is in.
>

The patch looks good to me after all i386 changes have been checked
in.

Thanks.


-- 
H.J.