This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] i386: Do not set internal_function
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 14 Aug 2017 14:35:03 +0200
- Subject: Re: [PATCH] i386: Do not set internal_function
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B3AE47EA80
- References: <20170814113616.3D29C401ADB67@oldenburg.str.redhat.com> <CAMe9rOptUHdVTg-BZR49YRBZJAkxyodbDZL--DVLFfazUXJPqQ@mail.gmail.com>
On 08/14/2017 02:32 PM, H.J. Lu wrote:
> On Mon, Aug 14, 2017 at 4:36 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> All calls to functions with the internal_function attribute
>> have been removed from assembler implementations, which means that
>> the definition of internal_function can be changed at the C level
>> without causing ABI issues with assembler code.
>>
>> _dl_fixup still uses a regparm calling convention on i386, but this
>> is controlled through ARCH_FIXUP_ATTRIBUTE, not internal_function.
>>
>> 2017-08-14 Florian Weimer <fweimer@redhat.com>
>>
>> i386: Do not set internal_function.
>> * config.h.in (USE_REGPARMS, internal_function): Remove.
>> * sysdeps/i386/configure.ac (USE_REGPARMS): Likewise.
>> * sysdeps/i386/configure (USE_REGPARMS): Likewise.
>>
>
> Does include/libc-symbols.h still define internal_function?
Yes, the macro generic definition is still present, but it expands to
nothing.
Completely removing internal_function is a separate cleanup. I would
like to tackle this on a per-subdirectory basis once this change is in.
Thanks,
Florian