This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] i386: Do not set internal_function
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 14 Aug 2017 05:32:51 -0700
- Subject: Re: [PATCH] i386: Do not set internal_function
- Authentication-results: sourceware.org; auth=none
- References: <20170814113616.3D29C401ADB67@oldenburg.str.redhat.com>
On Mon, Aug 14, 2017 at 4:36 AM, Florian Weimer <fweimer@redhat.com> wrote:
> All calls to functions with the internal_function attribute
> have been removed from assembler implementations, which means that
> the definition of internal_function can be changed at the C level
> without causing ABI issues with assembler code.
>
> _dl_fixup still uses a regparm calling convention on i386, but this
> is controlled through ARCH_FIXUP_ATTRIBUTE, not internal_function.
>
> 2017-08-14 Florian Weimer <fweimer@redhat.com>
>
> i386: Do not set internal_function.
> * config.h.in (USE_REGPARMS, internal_function): Remove.
> * sysdeps/i386/configure.ac (USE_REGPARMS): Likewise.
> * sysdeps/i386/configure (USE_REGPARMS): Likewise.
>
Does include/libc-symbols.h still define internal_function?
--
H.J.