This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING] [PATCH] sys/ptrace.h: remove obsolete Linux PTRACE_SEIZE_DEVEL constant
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Marcus Shawcroft <marcus dot shawcroft at arm dot com>, Szabolcs Nagy <szabolcs dot nagy at arm dot com>, Mike Frysinger <vapier at gentoo dot org>, Stefan Liebler <stli at linux dot vnet dot ibm dot com>, "David S. Miller" <davem at davemloft dot net>, libc-alpha at sourceware dot org
- Date: Tue, 8 Aug 2017 15:07:13 -0400
- Subject: Re: [PING] [PATCH] sys/ptrace.h: remove obsolete Linux PTRACE_SEIZE_DEVEL constant
- Authentication-results: sourceware.org; auth=none
- References: <20170808163039.GD4763@altlinux.org>
On 08/08/2017 12:30 PM, Dmitry V. Levin wrote:
> On Tue, Aug 08, 2017 at 09:20:17AM -0400, Carlos O'Donell wrote:
>> On 08/07/2017 11:33 AM, Dmitry V. Levin wrote:
>>> Hi,
>>>
>>> Looks like among those few who care about sys/ptrace.h nobody feels
>>> experienced enough to review this change, so I'll go forward and commit it.
>>
>> Please tread carefully, and give the machine maintainer time to review, or
>> directly TO: the machine maintainers and ask for review.
>>
>> Lack of a response does not mean you can assume consensus. Follow up with
>> machine maintainers, even one ACK from a maintainer goes a long way to
>> knowing there is support for your change.
>
> JFYI, PTRACE_SEIZE_DEVEL was an architecture-independent constant.
Agreed, but the patch still touches machine-specific headers.
> There is absolutely no hurry, though, so let's give machine maintainers
> more time to review this obvious change.
In this case I think it is perfectly acceptable to track down reviews from
other developers, enough to get consensus that the generic change is OK.
For example if a couple of non-machine maintainers reviewed this an thought
it sensible, then you'd be OK to commit. With machine maintainers perhaps
tweaking this later.
--
Cheers,
Carlos.