This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/1] Fix iso 3166.def for TIWAN
- From: Mike FABIAN <mfabian at redhat dot com>
- To: AKHILESH KUMAR <akhilesh dot k at samsung dot com>
- Cc: "libc-alpha\@sourceware.org" <libc-alpha at sourceware dot org>
- Date: Thu, 03 Aug 2017 17:12:07 +0200
- Subject: Re: [PATCH 1/1] Fix iso 3166.def for TIWAN
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=mfabian at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E659AC0587D9
- References: <s9dlgn23pt2.fsf@redhat.com> <s9dd18kedy4.fsf@redhat.com> <1501243954-46361-1-git-send-email-akhilesh.k@samsung.com> <20170731033651epcms5p52492d7778d677ad4ff6e7fbbc360c708@epcms5p5> <CGME20170728121634epcas5p3db3df5730c42459ebe67d112f0a38c3f@epcms5p8> <20170803031709epcms5p80e653cb4f18b8559050222578ff78db3@epcms5p8>
AKHILESH KUMAR <akhilesh.k@samsung.com> wrote:
>>>> > DEFINE_COUNTRY_CODE ("SWITZERLAND", CH, CHE, 756)
>>>> > DEFINE_COUNTRY_CODE ("SYRIAN ARAB REPUBLIC", SY, SYR, 760)
>>>> > -DEFINE_COUNTRY_CODE ("TAIWAN, PROVINCE OF CHINA", TW, TWN, 158)
>>>> > +DEFINE_COUNTRY_CODE ("TAIWAN (PROVINCE OF CHINA)", TW, TWN, 158)
>>>>
>>>> I don’t really see why that is an improvement.
>>>
>>>
>>> This patch only make consistency
>>> Like
>>> DEFINE_COUNTRY_CODE ("SINT MAARTEN (DUTCH PART)", SX, SXM, 534)
>>> DEFINE_COUNTRY_CODE ("SAINT MARTIN (FRENCH PART)", MF, MAF, 663)
>>>
>>>
>>> Query:-
>>> 1- > looks some countries info are missing Like “KOSOVA” ?
>>
>>Maybe we don’t need an entry for Kosovo if we don’t have a locale for
>>Kosovo anyway at the moment.
>>
>
> Agree, Since no locale for “KOSOVA” currently, So we can Ignore this case
> Regarding current changes, They are related with consistency
I don’t get the consistency argument here, the current text already
looks fine to me.
--
Mike FABIAN <mfabian@redhat.com>