This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Removed redundant data for LC_MONETARY
- From: Mike FABIAN <mfabian at redhat dot com>
- To: AKHILESH KUMAR <akhilesh dot k at samsung dot com>
- Cc: Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>, "libc-alpha\@sourceware.org" <libc-alpha at sourceware dot org>, "hjl.tools\@gmail.com" <hjl dot tools at gmail dot com>
- Date: Thu, 27 Jul 2017 09:16:20 +0200
- Subject: Re: [PATCH v2] Removed redundant data for LC_MONETARY
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=mfabian at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2A8BA3E2A1
- References: <874ltzoz0y.fsf@linux.vnet.ibm.com> <1501055354-43092-1-git-send-email-akhilesh.k@samsung.com> <CGME20170726075319epcas5p16a487cd5294afbfd37015bfd06af8657@epcms5p7> <20170727035500epcms5p7b90e0c64a68589ff65f4dc6d6a2749e8@epcms5p7>
AKHILESH KUMAR <akhilesh.k@samsung.com> wrote:
>> diff --git a/localedata/locales/bn_IN b/localedata/locales/bn_IN
>> index b27af12..f8074b5 100644
>> --- a/localedata/locales/bn_IN
>> > +++ b/localedata/locales/bn_IN
>> > @@ -54,27 +54,7 @@ END LC_COLLATE
>> >
>> >
>> > LC_MONETARY
>>> -% This is the POSIX Locale definition the LC_MONETARY category
>>> -% generated by IBM Basic CountryPack Transformer.
>> > -% These are generated based on XML base Locale defintion file
>> > -% for IBM Class for Unicode.
>> > -%
>> > -int_curr_symbol "<U0049><U004E><U0052><U0020>"
>> > -currency_symbol "<U20B9>"
>> > -mon_decimal_point "<U002E>"
>> > -mon_thousands_sep "<U002C>"
>> > -mon_grouping 2;3
>>
>> mon_grouping is different than what hi_IN defines.
>>
>> > diff --git a/localedata/locales/te_IN b/localedata/locales/te_IN
>> > index e8c6424..a1f10e1 100644
>> > --- a/localedata/locales/te_IN
>> > +++ b/localedata/locales/te_IN
>> > @@ -75,27 +75,7 @@ END LC_COLLATE
>> >
>> >
>> > LC_MONETARY
>> -% This is the POSIX Locale definition the LC_MONETARY category
>> -% generated by IBM Basic CountryPack Transformer.
>> -% These are generated based on XML base Locale defintion file
>> -% for IBM Class for Unicode.
>> -%
>> -int_curr_symbol "<U0049><U004E><U0052><U0020>"
>> -currency_symbol "<U20B9>"
>> -mon_decimal_point "<U002E>"
>> -mon_thousands_sep "<U002C>"
>> -mon_grouping 3;2
>> -positive_sign ""
>> -negative_sign "<U002D>"
>> -int_frac_digits 2
>> -frac_digits 2
>> -p_cs_precedes 1
>> -p_sep_by_space 0
>> -n_cs_precedes 1
>> -n_sep_by_space 0
>>
>> Both p_sep_by_space and n_sep_by_space values were different than what
>> hi_IN defines.
>>
>> These changes are causing errors at stdlib/tst-strfmon_l.
>>
>>Are these changes really expected?
>
>
> I believe LC_MONETARY to be uniform across the country.
>
> Also In LC_MONETARY "mon_grouping" field in nation language “Hindi” seems wrong
> it could be 3;2
>
> I will check other field (p_sep_by_space and n_sep_by_space)
> and Share Fix patch soon
Please add some proof whether LC_MONETARY is uniform all over India, if
possible. I also guess that it is like that, but please make sure.
Also for the mon_grouping field, please make really sure what
the true value should be.
--
Mike FABIAN <mfabian@redhat.com>