This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Removed redundant data for LC_MONETARY
- From: AKHILESH KUMAR <akhilesh dot k at samsung dot com>
- To: Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc: "mfabian at redhat dot com" <mfabian at redhat dot com>, "hjl dot tools at gmail dot com" <hjl dot tools at gmail dot com>
- Date: Thu, 27 Jul 2017 03:55:00 +0000
- Subject: Re: [PATCH v2] Removed redundant data for LC_MONETARY
- Authentication-results: sourceware.org; auth=none
- Cms-type: 105P
- Dlp-filter: Pass
- References: <874ltzoz0y.fsf@linux.vnet.ibm.com> <1501055354-43092-1-git-send-email-akhilesh.k@samsung.com> <CGME20170726075319epcas5p16a487cd5294afbfd37015bfd06af8657@epcms5p7>
- Reply-to: akhilesh dot k at samsung dot com
> diff --git a/localedata/locales/bn_IN b/localedata/locales/bn_IN
> index b27af12..f8074b5 100644
> --- a/localedata/locales/bn_IN
> > +++ b/localedata/locales/bn_IN
> > @@ -54,27 +54,7 @@ END LC_COLLATE
> >
> >
> > LC_MONETARY
>> -% This is the POSIX Locale definition the LC_MONETARY category
>> -% generated by IBM Basic CountryPack Transformer.
> > -% These are generated based on XML base Locale defintion file
> > -% for IBM Class for Unicode.
> > -%
> > -int_curr_symbol "<U0049><U004E><U0052><U0020>"
> > -currency_symbol "<U20B9>"
> > -mon_decimal_point "<U002E>"
> > -mon_thousands_sep "<U002C>"
> > -mon_grouping 2;3
>
> mon_grouping is different than what hi_IN defines.
>
> > diff --git a/localedata/locales/te_IN b/localedata/locales/te_IN
> > index e8c6424..a1f10e1 100644
> > --- a/localedata/locales/te_IN
> > +++ b/localedata/locales/te_IN
> > @@ -75,27 +75,7 @@ END LC_COLLATE
> >
> >
> > LC_MONETARY
> -% This is the POSIX Locale definition the LC_MONETARY category
> -% generated by IBM Basic CountryPack Transformer.
> -% These are generated based on XML base Locale defintion file
> -% for IBM Class for Unicode.
> -%
> -int_curr_symbol "<U0049><U004E><U0052><U0020>"
> -currency_symbol "<U20B9>"
> -mon_decimal_point "<U002E>"
> -mon_thousands_sep "<U002C>"
> -mon_grouping 3;2
> -positive_sign ""
> -negative_sign "<U002D>"
> -int_frac_digits 2
> -frac_digits 2
> -p_cs_precedes 1
> -p_sep_by_space 0
> -n_cs_precedes 1
> -n_sep_by_space 0
>
> Both p_sep_by_space and n_sep_by_space values were different than what
> hi_IN defines.
>
> These changes are causing errors at stdlib/tst-strfmon_l.
>
>Are these changes really expected?
I believe LC_MONETARY to be uniform across the country.
Also In LC_MONETARY "mon_grouping" field in nation language “Hindi” seems wrong
it could be 3;2
I will check other field (p_sep_by_space and n_sep_by_space)
and Share Fix patch soon