This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] NSS test harness upgrade
- From: DJ Delorie <dj at redhat dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 19 Jul 2017 19:15:32 -0400
- Subject: Re: [patch] NSS test harness upgrade
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dj at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1838E356DF
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1838E356DF
- References: <xn1spcuyx4.fsf@greed.delorie.com> <87mv80nmjw.fsf@linux-m68k.org>
Andreas Schwab <schwab@linux-m68k.org> writes:
>> - savedmemcount = (size_t) *(savedend - sizeof (size_t));
>> + savedmemcount = *(size_t *) (savedend - sizeof (size_t));
>
> I don't see where savedend is aligned.
It's always a multiple of size_t away from the array we align for in
__copy_grp, since that's where the data comes from.
Unless there's *another* place where we put together that weird
undocumented layout of the data - in which case, we shouln't ;-)