This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[Patch] Fix localedata test builds with latest GCC
- From: Steve Ellcey <sellcey at cavium dot com>
- To: libc-alpha at sourceware dot org
- Cc: zackw at panix dot com
- Date: Wed, 19 Jul 2017 13:14:06 -0700
- Subject: [Patch] Fix localedata test builds with latest GCC
- Authentication-results: sourceware.org; auth=none
- Reply-to: sellcey at cavium dot com
While testing the latest glibc sources with the latest (ToT) GCC, I ran
into some build failures (during testing, not during the glibc build).
This patch fixes the build failures in the localedata subdirectory. I
believe these started failing with this GCC patch:
https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00537.html
It does not look like older GCC's complain about not understanding this
option so there does not seem to be any need to conditionalize its usage.
Ok to checkin?
Steve Ellcey
sellcey@cavium.com
2017-07-19 Steve Ellcey <sellcey@cavium.com>
* localedata/Makefile (CFLAGS-tst_iswalnum.c, CFLAGS-tst_iswalpha.c
CFLAGS-tst_iswcntrl.c, CFLAGS-tst_iswdigit.c, CFLAGS-tst_iswgraph.c,
CFLAGS-tst_iswlower.c, CFLAGS-tst_iswprint.c, CFLAGS-tst_iswpunct.c,
CFLAGS-tst_iswspace.c, CFLAGS-tst_iswupper.c, CFLAGS-tst_iswxdigit.c,
CFLAGS-tst_towlower.c, CFLAGS-tst_towupper.c): New macros.
diff --git a/localedata/Makefile b/localedata/Makefile
index 47ca39d..20c5921 100644
--- a/localedata/Makefile
+++ b/localedata/Makefile
@@ -122,6 +122,21 @@ $(inst_i18ndir)/charmaps/%.gz: charmaps/% $(+force)
# Install the locale source files in the appropriate directory.
$(inst_i18ndir)/locales/%: locales/% $(+force); $(do-install)
+# These tests use multistatement macros from tests-mbwc/tst_funcs.h
+# and will not compile with GCC 8.1 without the warning turned off.
+CFLAGS-tst_iswalnum.c = -Wno-multistatement-macros
+CFLAGS-tst_iswalpha.c = -Wno-multistatement-macros
+CFLAGS-tst_iswcntrl.c = -Wno-multistatement-macros
+CFLAGS-tst_iswdigit.c = -Wno-multistatement-macros
+CFLAGS-tst_iswgraph.c = -Wno-multistatement-macros
+CFLAGS-tst_iswlower.c = -Wno-multistatement-macros
+CFLAGS-tst_iswprint.c = -Wno-multistatement-macros
+CFLAGS-tst_iswpunct.c = -Wno-multistatement-macros
+CFLAGS-tst_iswspace.c = -Wno-multistatement-macros
+CFLAGS-tst_iswupper.c = -Wno-multistatement-macros
+CFLAGS-tst_iswxdigit.c = -Wno-multistatement-macros
+CFLAGS-tst_towlower.c = -Wno-multistatement-macros
+CFLAGS-tst_towupper.c = -Wno-multistatement-macros
ifeq ($(run-built-tests),yes)
generated-dirs += $(LOCALES)