This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Avoid .symver on common symbols [BZ #21666]
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- Cc: Florian Weimer <fweimer at redhat dot com>, nd <nd at arm dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 12 Jul 2017 10:10:32 -0700
- Subject: Re: [PATCH] Avoid .symver on common symbols [BZ #21666]
- Authentication-results: sourceware.org; auth=none
- References: <20170623161158.GA5384@gmail.com> <ef60f811-b227-cbc0-a8d6-ba8c3c13ea82@redhat.com> <CAMe9rOryBUqXQgYU=0mzD=6GAvr=zJHLwDfd3XqaFpS8KL0CUw@mail.gmail.com> <db778f3b-3a81-80e3-9589-294a6a432f97@redhat.com> <596654AA.2090008@arm.com>
On Wed, Jul 12, 2017 at 9:56 AM, Szabolcs Nagy <szabolcs.nagy@arm.com> wrote:
> On 23/06/17 22:13, Florian Weimer wrote:
>> On 06/23/2017 06:26 PM, H.J. Lu wrote:
>>
>>>> Does this result in a visible difference for applications? If yes,
>>>> please file a bug for this and reference it in the ChangeLog and commit
>>>> message.
>>>
>>> It will be very hard to tell since these symbols were exported from libc.so
>>> by accident and we only keep them in libc.so for backward binary compatibility.
>>> Application can no longer reference them from libc.so.
>>
>> Ah, it's the old <regexp.h> interface, and the symbols were exported
>> deliberately. We apparently do not have any tests for it.
>>
>>> Here is the updated patch. OK for master?
>>
>> Yes, please. Thanks.
>>
>
> i think this should be ok for backporting too
> since without it old releases cannot be built
> with new binutils.
>
I have ported it to hjl/pr21120/2.25 branch. I also backported 2 patches for
GCC 7. See:
https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/hjl/pr21120/2.25
--
H.J.