Re: [PATCHv2] Fix float128 IFUNC relocations on ppc64le [BZ #21707]

["Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>]

Florian Weimer <fweimer@redhat.com> writes:

> On 07/08/2017 08:31 PM, Tulio Magno Quites Machado Filho wrote:
>> Changes since version 1:
>> 
>>  - Added a testcase.  This is now validating both statically and
>>    dynamically linked executables.
>>  - Fixed an issue in the $(foreach ..) in sysdeps/powerpc/powerpc64le/Makefile.
>>  - Added a comment to csu/libc-start.c
>>  - Added a comment to csu/libc-tls.c
>> 
>> -- 8< --
>> 
>> The patch proposed by Peter Bergner [1] to libgc in order to fix
>
> Typo, should be “libgcc”.

Fixed locally.

>> +__thread int bar;
>> +static int * bar_ptr = NULL;
>
> No space after “*”?

Fixed.

>> +  else {
>> +    printf ("FAIL: IFUNC resolver not called once.\n");
>> +    ret = 1;
>> +  }
>> +
>> +  if (&bar == bar_ptr)
>> +    printf ("PASS: Address read from IFUNC resolver is correct.\n");
>> +  else {
>> +    printf ("FAIL: Address read from IFUNC resolver is incorrect.\n");
>> +    ret = 1;
>> +  }
>
> The “{” should be on its own line.

Fixed both cases and re-indented the lines:

  else
    {
      printf ("FAIL: IFUNC resolver not called once.\n");
      ret = 1;
    }

  if (&bar == bar_ptr)
    printf ("PASS: Address read from IFUNC resolver is correct.\n");
  else
    {
      printf ("FAIL: Address read from IFUNC resolver is incorrect.\n");
      ret = 1;
    }

Thanks!

-- 
Tulio Magno