This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86-64: Align the stack in __tls_get_addr [BZ #21609]


On Fri, 2017-07-07 at 12:19 -0400, Carlos O'Donell wrote:
> On 07/06/2017 04:26 PM, Florian Weimer wrote:
> > I still think (c) is superior to the ___tls_get_addr (three _) solution.
> >  The three _s probably have to be made known to the sanitizers and to
> > valgrind, too.
> 
> That is a good 'Con' against (b). Is it true? We should have someone like
> Mark Wielaard comment on this?

valgrind doesn't treat __tls_get_addr special. I haven't checked what
__tls_get_addr does precisely. But apparently it operates on well
defined memory locations, so doesn't need any special treatment.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]