This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86-64: Align the stack in __tls_get_addr [BZ #21609]

On 07/06/2017 05:44 PM, Alexander Monakov wrote:
> On Thu, 6 Jul 2017, H.J. Lu wrote:

>> Please take a look at the current master branch.  I have pushed a fix
>> today:
>>
>> https://sourceware.org/git/?p=glibc.git;a=commit;h=031e519c95c069abe4e4c7c59e2b4b67efccdee5

> Right, but my point was that by simply adding the attribute to two existing
> noinline functions all that new complexity could have been avoided.

At least the complexity is restricted to the x86-64 port.  Injecting the
x86-specific function attribute into generic code is not exactly
trivial, either.

Thanks,
Florian
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]