This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] tunables, aarch64: New tunable to override cpu
- From: Siddhesh Poyarekar <siddhesh at sourceware dot org>
- To: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Sat, 1 Jul 2017 19:53:24 +0530
- Subject: Re: [PATCH v2] tunables, aarch64: New tunable to override cpu
- Authentication-results: sourceware.org; auth=none
- References: <1498729954-15927-1-git-send-email-siddhesh@sourceware.org> <CAJA7tRYdSaZsXEAiiT5bspWGrtSehfbPqZDzV0y5-fL2yx1SSQ@mail.gmail.com>
- Reply-to: siddhesh at sourceware dot org
On Saturday 01 July 2017 03:43 AM, Ramana Radhakrishnan wrote:
> Shouldn't this be
>
> TUNABLE_GET (glibc, tune, cpu, const char * , NULL);
>
> I don't have write privileges in glibc but the attached appears to be
> an obvious fix and allows the build to complete. Are there any tests
> for tunables btw ?
Oops, I had tested these using glibc.tune.mcpu and then did a trivial
refactoring (incorrectly, evidently) to call it glibc.tune.cpu. Fixed
in master.
Some of the earlier tunables have tests (malloc.check for example) but
not all of them. The recent ifunc selection tunables don't have any
tests in the glibc testsuite.
I should be able to write a trivial test that at least ensures that
tunables are picked up, i.e. make them typo-safe. I'll give it a shot
next week.
Siddhesh