This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] i386: Increase MALLOC_ALIGNMENT to 16 [BZ #21120]
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 29 Jun 2017 11:06:58 -0700
- Subject: Re: [PATCH] i386: Increase MALLOC_ALIGNMENT to 16 [BZ #21120]
- Authentication-results: sourceware.org; auth=none
- References: <20170629173030.GA25414@intel.com> <email@example.com>
On Thu, Jun 29, 2017 at 10:55 AM, Carlos O'Donell <firstname.lastname@example.org> wrote:
> On 06/29/2017 01:30 PM, H.J. Lu wrote:
>> GCC 7 changed the definition of max_align_t on i386:
>> As a result, glibc malloc no longer returns memory blocks which are as
>> aligned as max_align_t requires.
>> This causes malloc/tst-malloc-thread-fail to fail with an error like this
>> error: allocation function 0, size 144 not aligned to 16
>> This patch increases the malloc alignment to 16 for i386.
>> Tested on i386 with GCC 7 and on x86-64. OK for master?
>> [BZ #21120]
>> * sysdeps/generic/malloc-alignment.h: New file.
>> * sysdeps/i386/malloc-alignment.h: Likewise.
>> * sysdeps/generic/malloc-machine.h: Include <malloc-alignment.h>.
> Please use malloc-machine.h which was the previous header that provided
> machine-dependent malloc definitions. That way we remain consistent across
> releases and make it easier to backport such changes without adding a new
It won't work too well for Hurd since we have
What will Hurd/i386 get? malloc-alignment.h handles it automatically.
> OK with that change.