This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Single threaded stdio optimization
On Thursday 29 June 2017 05:11 PM, Siddhesh Poyarekar wrote:
> The patch looks OK except for the duplication (and a missing comment
> below), which looks a bit clumsy. How about something like this instead:
>
> bool need_lock = _IO_need_lock (fp);
>
> if (need_lock)
> _IO_flockfile (fp);
> result = _IO_ferror_unlocked (fp);
> if (need_lock)
> _IO_funlockfile (fp);
>
> return result;
>
> You could probably make some kind of a macro out of this, I haven't
> looked that hard.
I forgot that Torvald had commented (off-list, the thread broke somehow)
that it would be important to try and measure how much worse this makes
the multi-threaded case worse.
Siddhesh