This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v2] zic, various tests: use 64-bit stat/ftw/readdir functions
On Mon, 26 Jun 2017, Nick Alcock wrote:
> > A test of ftw should arguably be using ftw exactly, not ftw64, and
> > probably be paired with a corresponding tests (using a shared test
> > skeleton) that tests the same things for ftw64. I.e., adding appropriate
> > checks so this test doesn't fail for 64-bit inode numbers might be better,
> > to avoid changing what function this test tests.
> i.e. UNSUPPORTED-out this test iff it EOVERFLOWs, and have another
> bug-ftw64-2.c that uses ftw64 instead and is run unconditionally?
Yes, exactly. tst-regex.c is different because that's not testing the I/O
functions, just using them, so unconditionally using fstat64 makes sense
Joseph S. Myers