This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] rtld: Reject overly long LD_AUDIT path elements
- From: Florian Weimer <fweimer at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 26 Jun 2017 11:46:03 +0200
- Subject: Re: [PATCH] rtld: Reject overly long LD_AUDIT path elements
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 36A1880F7B
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 36A1880F7B
- References: <20170619161345.7CC73402AEC3E@oldenburg.str.redhat.com> <mvmzicvp23k.fsf@suse.de> <54c5074e-8b7c-7b3b-e5b1-02ee18a7cabe@redhat.com> <mvmvanjozna.fsf@suse.de>
On 06/26/2017 11:40 AM, Andreas Schwab wrote:
> On Jun 26 2017, Florian Weimer <fweimer@redhat.com> wrote:
>
>> On 06/26/2017 10:47 AM, Andreas Schwab wrote:
>>
>>> Why do you need all that complexity?
>>
>> Do you mean the external iterator instead of just writing a loop?
>>
>> I did this so that the patch can be backported without changes.
>> Otherwise, we would have to reindent the audit module process loop (or
>> move it to separate function for clarity), and this will introduce a lot
>> of conflicts because there have been quite a few trivial changes to the
>> loop body.
>
> That's not a good reason for overly complex code.
I had hoped to clean this up after the new dl-minimal malloc went in,
but I can do so now if you want that.
Thanks,
Florian