This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] rtld: Reject overly long LD_AUDIT path elements
On Jun 26 2017, Florian Weimer <email@example.com> wrote:
> On 06/26/2017 10:47 AM, Andreas Schwab wrote:
>> Why do you need all that complexity?
> Do you mean the external iterator instead of just writing a loop?
> I did this so that the patch can be backported without changes.
> Otherwise, we would have to reindent the audit module process loop (or
> move it to separate function for clarity), and this will introduce a lot
> of conflicts because there have been quite a few trivial changes to the
> loop body.
That's not a good reason for overly complex code.
Andreas Schwab, SUSE Labs, firstname.lastname@example.org
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."