This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] x86-64: memcmp-avx2-movbe.S needs saturating subtraction [BZ #21662]

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: Florian Weimer <fweimer at redhat dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Fri, 23 Jun 2017 08:08:13 -0700
Subject: Re: [PATCH] x86-64: memcmp-avx2-movbe.S needs saturating subtraction [BZ #21662]
Authentication-results: sourceware.org; auth=none
References: <20170623132026.82F2D4017D45E@oldenburg.str.redhat.com> <6fec374c-177f-b8e8-d7a3-ab10d7dab136@redhat.com>

On Fri, Jun 23, 2017 at 6:51 AM, Florian Weimer <fweimer@redhat.com> wrote:
> I think this revised patch is an improvement because it avoids adding a
> branch.
>
> Thanks,
> Florian

The memcmp-avx2-movbe.S part is OK.  For

(check_result, do_random_tests): Write error messages to standard
output.

any particular reason to replace error with printf?

Thanks.

-- 
H.J.

Follow-Ups:
- Re: [PATCH] x86-64: memcmp-avx2-movbe.S needs saturating subtraction [BZ #21662]
  - From: Florian Weimer

References:
- [PATCH] x86-64: memcmp-avx2-movbe.S needs saturating subtraction [BZ #21662]
  - From: Florian Weimer
- Re: [PATCH] x86-64: memcmp-avx2-movbe.S needs saturating subtraction [BZ #21662]
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]