This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 4/6] powerpc64le: Require at least GCC 6.2 for powerpc64le

From: Steven Munroe <munroesj at linux dot vnet dot ibm dot com>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: "Gabriel F. T. Gomes" <gftg at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
Date: Thu, 22 Jun 2017 10:25:36 -0500
Subject: Re: [PATCH v2 4/6] powerpc64le: Require at least GCC 6.2 for powerpc64le
Authentication-results: sourceware.org; auth=none
References: <1498067125-30472-1-git-send-email-gftg@linux.vnet.ibm.com> <1498067125-30472-5-git-send-email-gftg@linux.vnet.ibm.com> <alpine.DEB.2.20.1706212327320.12128@digraph.polyomino.org.uk>
Reply-to: munroesj at linux dot vnet dot ibm dot com

On Wed, 2017-06-21 at 23:27 +0000, Joseph Myers wrote:
> I see no problem with this, but as far as I'm concerned it's for powerpc 
> maintainers to review.
> 
I am Ok with this as it is specific to powerpc64le and will not impact
the other PPC platforms.

But I would prefer a compile test for __float128 and the require 'q'
suffix builtins over s GCC version test. This would allow for clang/llvm
compiles (once they complete their float128 support).

I approve with the change noted above.

Follow-Ups:
- Re: [PATCH v2 4/6] powerpc64le: Require at least GCC 6.2 for powerpc64le
  - From: Joseph Myers

References:
- [PATCH v2 0/6] Enable float128 on powerpc64le
  - From: Gabriel F. T. Gomes
- [PATCH v2 4/6] powerpc64le: Require at least GCC 6.2 for powerpc64le
  - From: Gabriel F. T. Gomes
- Re: [PATCH v2 4/6] powerpc64le: Require at least GCC 6.2 for powerpc64le
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]