This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] manual: Refactor documentation of CHAR_BIT.
- From: Florian Weimer <fweimer at redhat dot com>
- To: Rical Jasan <ricaljasan at pacific dot net>, libc-alpha at sourceware dot org
- Cc: Joseph Myers <joseph at codesourcery dot com>, Zack Weinberg <zackw at panix dot com>, Carlos O'Donell <carlos at redhat dot com>, Michael Kerrisk <mtk dot manpages at gmail dot com>
- Date: Thu, 22 Jun 2017 15:23:47 +0200
- Subject: Re: [PATCH v3] manual: Refactor documentation of CHAR_BIT.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 482237F40E
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 482237F40E
- References: <20170620112321.29338-1-ricaljasan@pacific.net> <20170620134418.31324-1-ricaljasan@pacific.net>
On 06/20/2017 03:44 PM, Rical Jasan wrote:
> @@ -628,11 +628,10 @@ There is no operator in the C language that can give you the number of
> bits in an integer data type. But you can compute it from the macro
> @code{CHAR_BIT}, defined in the header file @file{limits.h}.
Sorry for scope creep, but the paragraph is inaccurate: We now have
*_WIDTH macros, and you actually cannot easily compute the number of
usable bits in a portable manner.
Rest of the patch looks fine to me.
Thanks,
Florian