This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v2 6/6] powerpc64le: Enable float128
On Wed, 21 Jun 2017, Gabriel F. T. Gomes wrote:
> + New <math.h> functions from ISO/IEC TS 18661-3:
You say "functions" here, but actually some macros are included in the
> + The following <wchar.h> function is added to glibc as a GNU extension:
> + - Wide String Conversion Function: wsctof128.
You're missing mention of strtof128_l and wcstof128_l as GNU extensions
for the respective headers.
> diff --git a/include/float.h b/include/float.h
> diff --git a/manual/libm-err-tab.pl b/manual/libm-err-tab.pl
The changes to these files are OK, and should be committed now, as they
aren't powerpc-specific, presuming it doesn't break the manual build to
add the libm-err-tab.pl changes before there are actually any float128
ulps checked in.
> diff --git a/sysdeps/powerpc/powerpc64le/fpu/sfp-machine.h b/sysdeps/powerpc/powerpc64le/fpu/sfp-machine.h
> new file mode 100644
> index 0000000..f0fc4c4
> --- /dev/null
> +++ b/sysdeps/powerpc/powerpc64le/fpu/sfp-machine.h
> @@ -0,0 +1,119 @@
> +/* Decide whether to use 64 or 32-bit types to do the emulation. If we are
> + doing IEEE-128 with VSX, use 64-bit emulation even if we are compiling for a
> + 32-bit target. */
This comment seems inapplicable now the file has been cut down to the
Joseph S. Myers