This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] vfprintf: Remove unused argument from printf_unknown
- From: fweimer at redhat dot com (Florian Weimer)
- To: libc-alpha at sourceware dot org
- Date: Mon, 19 Jun 2017 18:23:19 +0200
- Subject: [PATCH] vfprintf: Remove unused argument from printf_unknown
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 04649145F83
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 04649145F83
2017-06-19 Florian Weimer <fweimer@redhat.com>
* stdio-common/vfprintf.c (printf_unknown): Remove unused argument.
(printf_positional): Adjust.
diff --git a/stdio-common/vfprintf.c b/stdio-common/vfprintf.c
index 0a5e541..9cd4683 100644
--- a/stdio-common/vfprintf.c
+++ b/stdio-common/vfprintf.c
@@ -1272,8 +1272,7 @@ static int printf_positional (_IO_FILE *s,
const char *grouping, THOUSANDS_SEP_T);
/* Handle unknown format specifier. */
-static int printf_unknown (FILE *, const struct printf_info *,
- const void *const *) __THROW;
+static int printf_unknown (FILE *, const struct printf_info *) __THROW;
/* Group digits of number string. */
static CHAR_T *group_number (CHAR_T *, CHAR_T *, CHAR_T *, const char *,
@@ -2035,19 +2034,8 @@ printf_positional (_IO_FILE *s, const CHAR_T *format, int readonly_format,
LABEL (form_unknown):
{
- unsigned int i;
- const void **ptr;
-
- ptr = alloca (specs[nspecs_done].ndata_args
- * sizeof (const void *));
-
- /* Fill in an array of pointers to the argument values. */
- for (i = 0; i < specs[nspecs_done].ndata_args; ++i)
- ptr[i] = &args_value[specs[nspecs_done].data_arg + i];
-
/* Call the function. */
- function_done = printf_unknown (s, &specs[nspecs_done].info,
- ptr);
+ function_done = printf_unknown (s, &specs[nspecs_done].info);
/* If an error occurred we don't have information about #
of chars. */
@@ -2079,8 +2067,7 @@ printf_positional (_IO_FILE *s, const CHAR_T *format, int readonly_format,
/* Handle an unknown format specifier. This prints out a canonicalized
representation of the format spec itself. */
static int
-printf_unknown (FILE *s, const struct printf_info *info,
- const void *const *args)
+printf_unknown (FILE *s, const struct printf_info *info)
{
int done = 0;