This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Patch 2 of 2 for ILP32 aarch64
- From: Steve Ellcey <sellcey at cavium dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>, Steve Ellcey <sellcey at caviumnetworks dot com>, Joseph Myers <joseph at codesourcery dot com>
- Cc: nd at arm dot com, libc-alpha <libc-alpha at sourceware dot org>
- Date: Tue, 13 Jun 2017 12:06:53 -0700
- Subject: Re: [PATCH] Patch 2 of 2 for ILP32 aarch64
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <1487781046.2866.153.camel@caviumnetworks.com> <alpine.DEB.2.20.1702221702490.8704@digraph.polyomino.org.uk> <1487879964.2866.181.camel@caviumnetworks.com> <alpine.DEB.2.20.1702240033550.6066@digraph.polyomino.org.uk> <1487980010.2866.198.camel@caviumnetworks.com> <593A60B1.6090100@arm.com> <593A7CEC.2040001@arm.com> <593E6999.6050405@arm.com> <1497284101.13346.104.camel@cavium.com> <593EC0AE.8070906@arm.com> <593FABC2.7020108@arm.com>
- Reply-to: sellcey at cavium dot com
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Tue, 2017-06-13 at 10:09 +0100, Szabolcs Nagy wrote:
>
> FAIL: nptl/tst-initializers1
> FAIL: nptl/tst-initializers1-c11
> FAIL: nptl/tst-initializers1-c89
> FAIL: nptl/tst-initializers1-c99
> FAIL: nptl/tst-initializers1-gnu11
> FAIL: nptl/tst-initializers1-gnu89
> FAIL: nptl/tst-initializers1-gnu99
I took a look at these failures and saw that
__PTHREAD_RWLOCK_INT_FLAGS_SHARED is only being set when in 64 bit
mode. I updated sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h to
define this macro and that fixed these failures. I will include that
change in my next patch submission (currently waiting on the kernel
patches).
Steve Ellcey
sellcey@cavium.com
% git diff sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h
diff --git a/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h
b/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h
index d13a75d..9aa9f04 100644
--- a/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h
+++ b/sysdeps/aarch64/nptl/bits/pthreadtypes-arch.h
@@ -65,5 +65,6 @@ struct __pthread_rwlock_arch_t
};
#define __PTHREAD_RWLOCK_ELISION_EXTRA 0
+#define __PTHREAD_RWLOCK_INT_FLAGS_SHARED 1
#endif /* bits/pthreadtypes.h */