This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 6/6] PowerPC64 ELFv2 PPC64_OPT_LOCALENTRY
Alan Modra <amodra@gmail.com> writes:
> On Thu, Jun 01, 2017 at 10:41:45PM +0930, Alan Modra wrote:
>> diff --git a/sysdeps/powerpc/powerpc64/dl-machine.h b/sysdeps/powerpc/powerpc64/dl-machine.h
> [snip]
>> + && (STO_PPC64_LOCAL_MASK & refsym->st_other) == 0
>> + && (STO_PPC64_LOCAL_MASK & sym->st_other) != 0)
>> + _dl_error_localentry (map, refsym);
> [snip]
>> +extern void attribute_hidden _dl_error_localentry (struct link_map *map,
>> + const Elf64_Sym *refsym);
>
> The above of course is stupid and results in warnings "implicit
> declaration of function" and "conflicting types". I was accidentally
> building with --disable-werror, a thing I don't normally do, so missed
> seeing the error. The following revised patch fixes this and puts
> _dl_error_localentry definition inside #if _CALL_ELF == 2.
Looks good to me.
Do you plan to recover the commit message from the previous version of the
patch?
--
Tulio Magno