This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 03/17] support: Add optstring support

From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
Date: Tue, 13 Jun 2017 08:55:52 -0300
Subject: Re: [PATCH 03/17] support: Add optstring support
Authentication-results: sourceware.org; auth=none
References: <1496956411-25594-1-git-send-email-adhemerval.zanella@linaro.org> <1496956411-25594-4-git-send-email-adhemerval.zanella@linaro.org> <32e33d18-10a5-e606-7f2a-d34950c6474e@redhat.com>


On 13/06/2017 06:22, Florian Weimer wrote:
> On 06/08/2017 11:13 PM, Adhemerval Zanella wrote:
>> +#ifdef CMDLINE_OPTSTRING
>> +  test_config.optstring = CMDLINE_OPTSTRING;
>> +#else
>> +  test_config.optstring = "+";
> 
> Why not "+" CMDLINE_OPTSTRING, for consistency?
> 
> Otherwise, this looks good to me.
> 
> Thanks,
> Florian
> 

I will add this change.

References:
- [PATCH 00/17] posix: glob fixes and refactor
  - From: Adhemerval Zanella
- [PATCH 03/17] support: Add optstring support
  - From: Adhemerval Zanella
- Re: [PATCH 03/17] support: Add optstring support
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]