This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHv2] Add a way to bypass the PLT when calling getauxval


Florian Weimer <fweimer@redhat.com> writes:

> "Tulio Magno Quites Machado Filho" <tuliom@linux.vnet.ibm.com> writes:
>
>> +extern __typeof(getauxval) __getauxval;
>
> Missing space before paren.

Fixed locally.

>> diff --git a/misc/getauxval.c b/misc/getauxval.c
>> index c83fbce..14f4298 100644
>> --- a/misc/getauxval.c
>> +++ b/misc/getauxval.c
>> @@ -43,3 +43,4 @@ __getauxval (unsigned long int type)
>>  }
>>  
>>  weak_alias (__getauxval, getauxval)
>> +libc_hidden_def (__getauxval)
>
> Looks good.

I'll push this patch with the fix.

Thanks!

-- 
Tulio Magno


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]