This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 5/9] float128: Add strfromf128


On Fri, 2 Jun 2017, Gabriel F. T. Gomes wrote:

> @@ -173,6 +176,11 @@ extern int strfromf (char *__dest, size_t __size, const char *__format,
>  extern int strfroml (char *__dest, size_t __size, const char *__format,
>  		     long double __f)
>       __THROW __nonnull ((3));
> +# if __HAVE_FLOAT128 && __GLIBC_USE (IEC_60559_TYPES_EXT)
> +extern int strfromf128 (char *__dest, size_t __size, const char * __format,
> +			_Float128 __f)
> +     __THROW __nonnull ((3));
> +# endif
>  #endif

As with other TS 18661-3 functions, the declaration should be outside the 
__GLIBC_USE (IEC_60559_BFP_EXT) block you've put it in, so that it's 
visible if __STDC_WANT_IEC_60559_TYPES_EXT__ is defined and the type is 
supported, even if __STDC_WANT_IEC_60559_BFP_EXT__ is not defined.

OK with that fixed.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]