This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Mark __tunables_init hidden and avoid PLT


On Thursday 25 May 2017 06:03 PM, H.J. Lu wrote:
> On Wed, May 24, 2017 at 10:57 PM, Siddhesh Poyarekar
> <siddhesh@gotplt.org> wrote:
>> On Thursday 25 May 2017 12:47 AM, H.J. Lu wrote:
>>> Since __tunables_init is internal to ld.so, we should mark it hidden
>>> to avoid PLT.  We should also avoid PLT when calling __tunable_set_val
>>> within ld.so.
>>
>> We don't export __tunables_init, so it shouldn't have a PLT anyway.  As
>> for __tunable_set_val, I have it in my patch 3/5:
>>
>> https://sourceware.org/ml/libc-alpha/2017-05/msg00654.html
>>
>> which needs minor rework before pushing.
>>
> 
> These can be in a simpler patch.  Here is the updated one.
> 
> OK for master?

OK.

Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]