This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nptl/tst-robust-fork: Increase timeout to 30 seconds.
- From: Florian Weimer <fweimer at redhat dot com>
- To: Carlos O'Donell <carlos at redhat dot com>, Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 18 May 2017 21:53:25 +0200
- Subject: Re: [PATCH] nptl/tst-robust-fork: Increase timeout to 30 seconds.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com AA1AC804EB
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AA1AC804EB
- References: <b063169a-ac91-8b6d-f052-b7b75e4534ce@redhat.com> <87tw4i3qy8.fsf@totoro.lan> <a062e92a-b368-90e2-9a70-bdb810e6b484@redhat.com>
On 05/18/2017 09:42 PM, Carlos O'Donell wrote:
> I disagree with Florian on the basis that we need to do
> _everything_ possible to have `make check` just work (tm)
> so developers don't have to set TIMEOUTFACTOR for average
> developer machines.
>
> I'm OK with 35s. I'll raise it to 35s and simplify the
> comment a bit.
>
> v2
> - Raise to 35s.
>
> OK with this?
I meant to come back to this. I was wrong, raising the timeout is fine.
I personally did this for some other tests, after all.
Thanks,
Florian