This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nptl/tst-robust-fork: Increase timeout to 30 seconds.
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Cc:
- Date: Thu, 18 May 2017 16:28:15 -0300
- Subject: Re: [PATCH] nptl/tst-robust-fork: Increase timeout to 30 seconds.
- Authentication-results: sourceware.org; auth=none
- References: <b063169a-ac91-8b6d-f052-b7b75e4534ce@redhat.com>
Carlos O'Donell <carlos@redhat.com> writes:
> The default test timeout is 20 seconds.
>
> On certain x86_64 hardware I can see tst-robust-fork test take 22 seconds on average.
>
> This results in spurious failures.
>
> I suggest we increase the timeout to 25 seconds and add a note about this.
>
> If nobody objects I'll check this in at some point next week when I get a
> free minute.
>
> I don't know if it's particularly useful to list the kernel version or
> hardware under which the slow timing came from i.e. linux 4.10 on an older
> i5-4690K.
>
> 2017-05-18 Carlos O'Donell <carlos@redhat.com>
>
> * nptl/tst-robust-fork.c (TIMEOUT): Define.
I agree with this change.
I have already proposed another patch increasing it to 35s [1].
IMO, 25 is too close to the time we both measured.
By the way, it isn't restricted to x86_64. I've seen this on powerpc as well.
[1] https://patchwork.sourceware.org/patch/19174/
--
Tulio Magno