This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH COMMITTED] inet_pton: Reformat in GNU style

From: Florian Weimer <fweimer at redhat dot com>
To: Andreas Schwab <schwab at suse dot de>
Cc: libc-alpha at sourceware dot org
Date: Mon, 15 May 2017 17:43:15 +0200
Subject: Re: [PATCH COMMITTED] inet_pton: Reformat in GNU style
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 13A8080F63
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 13A8080F63
References: <20170511124951.468BA417B242C@oldenburg.str.redhat.com> <mvminl77bli.fsf@suse.de>

On 05/11/2017 03:43 PM, Andreas Schwab wrote:

On Mai 11 2017, fweimer@redhat.com (Florian Weimer) wrote:

+/* Convert from presentation format (which usually means ASCII printable)
+ * to network format (which is usually some kind of binary format).
+ *


That's still not GNU style.

I posted a follow-up patch which hopefully addresses some of theremaining GNU-isms:


  https://sourceware.org/ml/libc-alpha/2017-05/msg00449.html

The goal of the original reformatting patch was to make it more obviouswhere the changes in the referenced patch actually are.


Thanks,
Florian

References:
- [PATCH COMMITTED] inet_pton: Reformat in GNU style
  - From: Florian Weimer
- Re: [PATCH COMMITTED] inet_pton: Reformat in GNU style
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]