This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 01/13] posix: Consolidate Linux pause syscall
On 12/05/2017 15:15, Florian Weimer wrote:
> On 05/12/2017 07:58 PM, Adhemerval Zanella wrote:
>> +/* sparc64 defines __NR_pause, however it is not supported (ENOSYS).
>> + Undefine so pause.c can use a correct alternative. */
>> +# ifdef __NR_pause
>> +# undef __NR_pause
>> +# endif
>
> I think you can #undef unconditionally, there isn't a warning for that.
Alright, I will change it.
>
> + return SYSCALL_CANCEL (ppoll, 0, 0, 0, 0, 0);
>
> I think some of the arguments should be NULL instead of 0.
I will change to SYSCALL_CANCEL (ppoll, NULL, 0, NULL, NULL).
>
> I'm not completely sure if an empty ppoll without a timeout has the required semantics, but I can't think of a reason why it would not work.
I though about Linux syscall with similar semantics regarding signals,
but I couldn't find one.