This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] posix: Fix and simplify default p{read,write}v implementation


On Thu, 11 May 2017, Adhemerval Zanella wrote:

> diff --git a/sysdeps/posix/preadv64.c b/sysdeps/posix/preadv64.c
> index 1986223..631c7f4 100644
> --- a/sysdeps/posix/preadv64.c
> +++ b/sysdeps/posix/preadv64.c
> @@ -1,9 +1,27 @@
> -#include <bits/wordsize.h>
> +/* Copyright (C) 2009-2017 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.

Missing descriptive comment above the copyright notice.

> diff --git a/sysdeps/posix/preadv_common.c b/sysdeps/posix/preadv_common.c
> new file mode 100644
> index 0000000..e17fe20
> --- /dev/null
> +++ b/sysdeps/posix/preadv_common.c
> @@ -0,0 +1,81 @@
> +/* Copyright (C) 2017 Free Software Foundation, Inc.

Likewise.

> diff --git a/sysdeps/posix/pwritev64.c b/sysdeps/posix/pwritev64.c
> index 4948d2e..7faae1d 100644
> --- a/sysdeps/posix/pwritev64.c
> +++ b/sysdeps/posix/pwritev64.c
> @@ -1,9 +1,27 @@
> -#include <bits/wordsize.h>
> +/* Copyright (C) 2009-2017 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.

Likewise.

> diff --git a/sysdeps/posix/pwritev_common.c b/sysdeps/posix/pwritev_common.c
> new file mode 100644
> index 0000000..59e19a0
> --- /dev/null
> +++ b/sysdeps/posix/pwritev_common.c
> @@ -0,0 +1,70 @@
> +/* Copyright (C) 2017 Free Software Foundation, Inc.

Likewise.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]