This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Use __glibc_reserved convention in mcontext, sigcontext (bug 21457)
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Date: Wed, 3 May 2017 22:25:45 -0400
- Subject: Re: Use __glibc_reserved convention in mcontext, sigcontext (bug 21457)
- Authentication-results: sourceware.org; auth=none
- References: <alpine.DEB.2.20.1705032243300.13632@digraph.polyomino.org.uk>
On 05/03/2017 06:43 PM, Joseph Myers wrote:
> This patch implements the most straightforward part of fixing
> namespace issues for sys/ucontext.h and related headers: where fields
> in sys/ucontext.h or bits/sigcontext.h are named "reserved", "padding"
> or similar, they are renamed to use the __glibc_reserved* naming
> convention. It does not change fields with a leading underscore, or
> even those with a prefix such as uc_ or sc_. It only fixes a small
> part of bug 21457, so no XFAILs are removed.
>
> Tested for x86_64 and x86, and with build-many-glibcs.py.
>
> 2017-05-03 Joseph Myers <joseph@codesourcery.com>
>
> [BZ #21457]
> * sysdeps/unix/sysv/linux/mips/sys/ucontext.h
> [_MIPS_SIM != _ABIO32] (mcontext_t): Rename field reserved to
> __glibc_reserved1.
> * sysdeps/unix/sysv/linux/x86/bits/sigcontext.h
> (struct _fpx_sw_bytes): Rename field padding to __glibc_reserved1.
> (struct _fpxreg): Likewise.
> [!__x86_64__] (struct _fpstate): Rename field reserved to
> __glibc_reserved1. Rename field padding to __glibc_reserved2.
> [__x86_64__] (struct _fpstate): Rename field padding to
> __glibc_reserved1.
> (struct _xsave_hdr): Rename field reserved1 to __glibc_reserved1.
> Rename field reserved2 to __glibc_reserved2.
> * sysdeps/unix/sysv/linux/x86/sys/ucontext.h
> [__x86_64__] (struct _libc_fpxreg): Rename field padding to
> __glibc_reserved1.
> [__x86_64__] (struct _libc_fpstate): Rename field padding to
> __glibc_reserved1.
OK.
I looked to see if gdb used any of the named reserved fields, or if any
other low-level program did, like strace, but I couldn't find any.
--
Cheers,
Carlos.