This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 3/3] posix: Implement preadv2 and pwritev2


On 02/05/2017 11:37, Christoph Hellwig wrote:
> On Tue, May 02, 2017 at 11:33:32AM -0300, Adhemerval Zanella wrote:
>> So default implementation just ignore the flag argument and calls generic
>> preadv/pwritev.
> 
> Please don't do that, it's actively dangerous.  Just fail the call.
> 

This a misleading commit comment from my part (I forgot to actually update
the commit log).  In fact, I am following the suggestion from Zack and
returning EINVAL for unsupported flags in generic implementation (which
are currently none).  So the flags are not really ignored, but rather
it will make the default implementation fails.

[1] https://sourceware.org/ml/libc-alpha/2017-04/msg00565.html
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]