This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] posix: Remove ununsed posix_spawn internal assignment
On 24/04/2017 10:01, Andreas Schwab wrote:
> On Apr 24 2017, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
>
>> * sysdeps/unix/sysv/linux/spawni.c (__spawni_child): Remove ununsed
>> assignment.
>
> Ok.
>
>> @@ -183,13 +182,13 @@ __spawni_child (void *arguments)
>>
>> /* Set the process group ID. */
>> if ((attr->__flags & POSIX_SPAWN_SETPGROUP) != 0
>> - && (ret = __setpgid (0, attr->__pgrp)) != 0)
>> + && (__setpgid (0, attr->__pgrp) != 0))
>> goto fail;
>>
>> /* Set the effective user and group IDs. */
>> if ((attr->__flags & POSIX_SPAWN_RESETIDS) != 0
>> - && ((ret = local_seteuid (__getuid ())) != 0
>> - || (ret = local_setegid (__getgid ())) != 0))
>> + && ((local_seteuid (__getuid ()) != 0)
>> + || (local_setegid (__getgid ()) != 0)))
>> goto fail;
>>
>> /* Execute the file actions. */
>
> The extra pair of parens around the expressions are no longer needed.
>
> Andreas.
>
Right, I will remove then on commit.