This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Why was the reallocarray function not added to glibc?

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Dennis Wölfing <denniswoelfing at gmx dot de>, Szabolcs Nagy <szabolcs dot nagy at arm dot com>, libc-alpha at sourceware dot org
Date: Fri, 7 Apr 2017 13:47:26 -0700
Subject: Re: Why was the reallocarray function not added to glibc?
Authentication-results: sourceware.org; auth=none
References: <d3ddd2fb-7f6c-3a85-5c00-666200275997@gmx.de> <58E26EF7.5070008@arm.com> <7afa6179-0e3b-0efe-023b-9c3cdd6da442@gmx.de>

The patch should use gcc builtins (when available) to detect integeroverflow instead of trying to do it by hand. You can do this by usingthe INT_MULTIPLY_OVERFLOW macro of Gnulib, documented here:


https://www.gnu.org/software/gnulib/manual/html_node/Integer-Type-Overflow.html

The easist way to use that macro is to copy gnulib intprops.h as-is intoglibc, and then use "#include <intprops.h>". It need not be a publicinclude file. Here's the current source:


http://git.savannah.gnu.org/cgit/gnulib.git/tree/lib/intprops.h

Follow-Ups:
- Re: Why was the reallocarray function not added to glibc?
  - From: Dennis Wölfing
- Re: Why was the reallocarray function not added to glibc?
  - From: Szabolcs Nagy

References:
- Why was the reallocarray function not added to glibc?
  - From: Dennis Wölfing
- Re: Why was the reallocarray function not added to glibc?
  - From: Szabolcs Nagy
- Re: Why was the reallocarray function not added to glibc?
  - From: Dennis Wölfing

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]