This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove CALL_THREAD_FCT macro
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 04 Apr 2017 21:22:35 +0200
- Subject: Re: [PATCH] Remove CALL_THREAD_FCT macro
- Authentication-results: sourceware.org; auth=none
- References: <1491332713-10642-1-git-send-email-adhemerval.zanella@linaro.org>
* Adhemerval Zanella:
> This patch removes CALL_THREAD_FCT macro usage and its defition for
> x86. For 32 bits it usage is only for force 16 stack alignment,
> however stack is already explicit aligned in clone syscall. For
> 64 bits and x32 it just a function call and there is no need to
> code it with inline assembly.
>
> Checked on i686-linux-gnu, x86_64-linux-gnu, and x86_64-linux-gnu-x32.
>
> * nptl/pthread_create.c (START_THREAD_DEFN): Remove
> CALL_THREAD_FCT macro usage.
> * sysdeps/i386/nptl/tls.h (CALL_THREAD_FCT): Remove definition.
> * sysdeps/x86_64/nptl/tls.h (CALL_THREAD_FCT): Likewise.
> * sysdeps/x86_64/32/nptl/tls.h: Remove file.
Looks good to me. Thanks.