This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] Add page tests to string/test-strnlen.
- From: Rajalakshmi Srinivasaraghavan <raji at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org, wainersm at linux dot vnet dot ibm dot com
- Date: Sat, 1 Apr 2017 13:02:26 +0530
- Subject: Re: [PATCH v3] Add page tests to string/test-strnlen.
- Authentication-results: sourceware.org; auth=none
- References: <20170331203729.23812-1-wainersm@linux.vnet.ibm.com>
On 04/01/2017 02:07 AM, Wainer dos Santos Moschetta wrote:
I checked following the new cases aren't duplicated of string/stratcliff.c
tests.
Changes since v2:
- Now using memset to initialize the string.
- Fixed indent of 2nd FOR_EACH_IMPL statement in do_page_test(), also
improved its explanation.
--- >8 ---
May be tricky for otimized implementations to handle strings around
page boundary once, for instance, it is performed unaligned loads or
when maxlen is used as a hint for vectorized loops. The test cases
should unveil regression bugs on these cases.
To some extend do_random_tests in string/test-strnlen tests strings
placed at page end but it does not cover all cases. So this change
adds tests which consists of placing strings of varying sizes ending
at the page boundary. It also combines with different values of maxlen.
Tested on ppc64le and x86_64.
2017-03-31 Wainer dos Santos Moschetta <wainersm@linux.vnet.ibm.com>
* string/test-strnlen.c (do_page_tests): New function
to check length of strings ending at the page boundary.
(test_main): Added call to the do_page_tests function.
LGTM
--
Thanks
Rajalakshmi S