This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Update elf tests to use the support test driver.
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: Wainer dos Santos Moschetta <wainersm at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Date: Thu, 30 Mar 2017 22:55:55 +0200
- Subject: Re: [PATCH] Update elf tests to use the support test driver.
- Authentication-results: sourceware.org; auth=none
- References: <20170329151407.6476-1-wainersm@linux.vnet.ibm.com> <32f6acde-964a-172d-43d7-69514932aaba@linaro.org>
* Adhemerval Zanella:
> There is no need to remove the static definition from this function and
> for all other every tests which includes the test-driver.c (since it will
> end up creating the main entrypoint anyway). I would avoid change it.
Agreed. The corresponding ChangeLog bit looks a bit strange as well:
* elf/next.c: Import support/test-driver.c instead of
test-skeleton.c and delete TEST_FUNCTION macro definition.
(do_test): adjust return attribute.
* elf/nodelete.c: Likewise.
I don't think any function attribute is changed in the patch.