This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v4] linux ttyname and ttyname_r: do not return wrong results

From: "Dmitry V. Levin" <ldv at altlinux dot org>
To: Christian Brauner <christian dot brauner at canonical dot com>
Cc: libc-alpha at sourceware dot org, Serge Hallyn <serge at hallyn dot com>, Christian Brauner <christian dot brauner at ubuntu dot com>
Date: Sun, 19 Mar 2017 21:10:38 +0300
Subject: Re: [PATCH v4] linux ttyname and ttyname_r: do not return wrong results
Authentication-results: sourceware.org; auth=none
References: <20170127145959.19084-1-christian.brauner@ubuntu.com> <20170127145959.19084-2-christian.brauner@ubuntu.com>

On Fri, Jan 27, 2017 at 03:59:59PM +0100, Christian Brauner wrote:
> From: Christian Brauner <christian.brauner@canonical.com>
> 
> If a link (say /proc/self/fd/0) pointing to a device, say /dev/pts/2, in a
> parent mount namespace is passed to ttyname, and a /dev/pts/2 exists (in a
> different devpts) in the current namespace, then it returns /dev/pts/2. But
> /dev/pts/2 is NOT the current tty, it is a different file and device.
> 
> Detect this case and return ENODEV. Userspace can choose to take this as a hint
> that the fd points to a tty device but to act on the fd rather than the link.
> 
> Signed-off-by: Serge Hallyn <serge@hallyn.com>
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Applied, thanks!


-- 
ldv

Attachment: signature.asc
Description: PGP signature

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]