This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] posix_spawn: use a larger min stack for -fstack-check [BZ #21253]
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Andrew Pinski <pinskia at gmail dot com>, Florian Weimer <fweimer at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Cc: <nd at arm dot com>
- Date: Fri, 17 Mar 2017 15:55:10 +0000
- Subject: Re: [PATCH] posix_spawn: use a larger min stack for -fstack-check [BZ #21253]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
- Nodisclaimer: True
- References: <20170316073012.22763-1-vapier@gentoo.org> <d2bf9ba2-b152-a747-6311-8078665c3dec@redhat.com> <20170316215236.GA24205@vapier> <CA+=Sn1nZKKiV-6qp3_sVnJrkBA1erQ9zaD4KrU1kE1NiF-4ieQ@mail.gmail.com> <20170316224124.GB24205@vapier> <8506619b-cc52-bf74-db4c-65f6cfd99c8e@linaro.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 17/03/17 14:38, Adhemerval Zanella wrote:
> My main concern is to add some hackery on an implementation that should be
> neutral to any compiler option and to keep try to adjust the initial stack
> size based on possible compiler version/architecture. In any way, I think
> the following patch should the -fstack-check if compiler is using it:
increasing the temp stack if the code is compiled
with -fstack-check is probably more correct than
than -fno-stack-check, but i think then it can be
increased unconditionally (allocating 4 pages
temporarily should be rarely an issue)