This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/4] Miscellaneous 'safe' testsuite changes.


On Mon, 20 Feb 2017, Zack Weinberg wrote:

> Finally, tst-setgetname.c was using kernel-features.h (also a no-go in
> _ISOMAC mode) just for one __ASSUME macro which it doesn't really need.

That macros is only used there.  Effectively, its function is to say "when 
we remove support for 2.6.32 kernels this code can be removed".  So if we 
remove the conditional we should also remove the macro definition and find 
some other way to track that this code should be removed when we increase 
the minimum kernel version for x86_64 / x86.  (Or we could decide that an 
extra year of support for 2.6.32 kernels on those architectures, compared 
to other architectures having required 3.2 in glibc 2.24, is enough, and 
just increase the minimum version so the conditional code is no longer 
needed.)

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]