Re: [PATCH] build-many-glibcs: don't crash if email is not configured

[Zack Weinberg <zackw at panix dot com>]

On Thu, Feb 16, 2017 at 5:19 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Thu, 16 Feb 2017, Zack Weinberg wrote:
>
>> The 'bot-cycle' action for build-many-glibcs is a convenient way to
>> not have to remember all the steps in keeping a many-glibcs tree up
>> to date ... or it would be, if the script could send mail _optionally_.
>> Make it so by skipping the mail step if mail isn't configured.
>>
>> OK?
>>
>>       * scripts/build-many-glibcs.py (bot_build_mail):  If the
>>       bot_config does not contain all of the necessary email-
>>       related settings, just print a warning and continue.
>
> I'm not sure what self.email_warning is for, given it's only set to True
> right before the script exits (so will always be False when tested).

Not so; bot_build_mail is called at the end of each "action" in a cycle:

        for a in actions:
            if must_build[a]:
                build_time = datetime.datetime.utcnow()
                print('Rebuilding %s at %s.' % (a, str(build_time)))
                self.bot_run_self([], a)
                self.load_build_state_json()
                self.bot_build_mail(a, build_time)
        print('Bot cycle done at %s.' % str(datetime.datetime.utcnow()))

And it takes the "action" as an argument, so making it send mail only
once for the entire process would be a fair bit of surgery.  Given
that, do you still want self.email_warning removed?  It seems to me it
would be annoying to get the warning more than once per invocation.

zw