This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Bug 20116: Fix use after free in pthread_create().

On 01/26/2017 11:01 PM, Siddhesh Poyarekar wrote:
> On Thursday 26 January 2017 07:22 PM, Torvald Riegel wrote:
>> This is OK, thanks.  I have a few minor comments on the wording of the
>> concurrency notes, but this shouldn't hold up committing this patch.
>>
>> Overall, the notes are good and really helpful, I think.  Good
>> description of the high-level synchronization scheme, which the
>> implementation can then be verified against.
>>
>> The fact that the high-level description points out an existing bug
>> (19511) is also a good thing.  IMO, this shows that we should have
>> proper concurrency notes for more of our concurrent code.
> 
> OK for 2.25.  Please feel free to commit follow-up comment fixes too if
> needed.

Thanks. I'll do this tomorrow.

I'm still pouring over dynamic linker notes and TLS setup for the other bug
I'm trying to see if we can fix.

-- 
Cheers,
Carlos.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]