This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] powerpc: Convert tests to the new support test-driver

From: Florian Weimer <fweimer at redhat dot com>
To: Rajalakshmi Srinivasaraghavan <raji at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
Date: Tue, 20 Dec 2016 08:38:01 +0100
Subject: Re: [PATCH] powerpc: Convert tests to the new support test-driver
Authentication-results: sourceware.org; auth=none
References: <20161219174939.12893-1-wainersm@linux.vnet.ibm.com> <93D74F78-ED78-482A-9A5F-4EF0AA3C6B99@linux.vnet.ibm.com> <5a2aad31-d976-13d5-3e86-a2ea07181f6f@linux.vnet.ibm.com>

On 12/20/2016 06:30 AM, Rajalakshmi Srinivasaraghavan wrote:

     +  status = xpthread_join (threads[i]);
        if (status)
          {
            return 1;
     @@ -184,5 +178,4 @@ do_test (void)

I don’t think you should omit the FAIL message here. Other than that,
LGTM.

I think xpthread_check_return() called from xpthread_join()
is already handling it.


Not for the status == NULL case.

Florian

References:
- [PATCH] powerpc: Convert tests to the new support test-driver
  - From: Wainer dos Santos Moschetta
- Re: [PATCH] powerpc: Convert tests to the new support test-driver
  - From: Carlos Eduardo Seo
- Re: [PATCH] powerpc: Convert tests to the new support test-driver
  - From: Rajalakshmi Srinivasaraghavan

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]